Release GIL when calling potentially-blocking functions#22
Merged
Conversation
|
This is a pretty critical improvement and really ought to be merged and released. |
Contributor
|
I haven't tested this, but have struggled with some issue that I believe are related to this. Would be great to get this merged. |
Owner
|
Thank you for your PR! Sorry for the very long wait. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for this useful library!
I think the library can release the GIL when the operation blocks.
So I propose to add
py::gil_scoped_releaseto functions with timeout parameter.